American Scoundrel: Roy Cohn’s Dark Journey from Joe McCarthy to Donald Trump is a vivid, deeply reported biography whose strongest achievement is to connect Cohn’s private opportunism with lasting institutional and political consequences